-
Notifications
You must be signed in to change notification settings - Fork 8.2k
fix: boards: update m5stack_cores3 configuration #81502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nashif
merged 3 commits into
zephyrproject-rtos:main
from
sylvioalves:bugfix/boards_m5stack_cores3
Nov 20, 2024
Merged
fix: boards: update m5stack_cores3 configuration #81502
nashif
merged 3 commits into
zephyrproject-rtos:main
from
sylvioalves:bugfix/boards_m5stack_cores3
Nov 20, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f4438e to
fdd7dc3
Compare
f38f1f4 to
c001d9b
Compare
c001d9b to
65ac181
Compare
soburi
reviewed
Nov 18, 2024
marekmatej
previously approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This board has a few issues handled by this PR: - Fix DTS entries to meet necessary flash partitions - Fix wrong kconfig entries realted to SoC model Signed-off-by: Sylvio Alves <[email protected]>
Modify this board docs to meet latest changes. Signed-off-by: Sylvio Alves <[email protected]>
This reverts commit 410c8a5 so that m5stack_cores3 can be tested properly. Signed-off-by: Sylvio Alves <[email protected]>
65ac181 to
39b6317
Compare
kartben
approved these changes
Nov 18, 2024
marekmatej
approved these changes
Nov 18, 2024
nordicjm
approved these changes
Nov 18, 2024
soburi
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This board has a few issues handled by this PR:
This fixes/updates 76914, which was old and not rebased as necessary, causing CI issues.
Fixes #81496