Skip to content

Conversation

@sylvioalves
Copy link
Contributor

@sylvioalves sylvioalves commented Nov 18, 2024

This board has a few issues handled by this PR:

  • Fix DTS entries to meet necessary flash partitions
  • Fix wrong kconfig entries related to SoC model
  • Fix documentation

This fixes/updates 76914, which was old and not rebased as necessary, causing CI issues.

Fixes #81496

@sylvioalves sylvioalves changed the title fix: boards: fix m5stack_cores3 configuration fix: boards: update m5stack_cores3 configuration Nov 18, 2024
@sylvioalves sylvioalves requested a review from nashif November 18, 2024 00:19
@sylvioalves sylvioalves added the Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. label Nov 18, 2024
@sylvioalves sylvioalves force-pushed the bugfix/boards_m5stack_cores3 branch from 9f4438e to fdd7dc3 Compare November 18, 2024 00:27
@sylvioalves sylvioalves changed the title fix: boards: update m5stack_cores3 configuration hotfix: boards: update m5stack_cores3 configuration Nov 18, 2024
@sylvioalves sylvioalves force-pushed the bugfix/boards_m5stack_cores3 branch 3 times, most recently from f38f1f4 to c001d9b Compare November 18, 2024 00:48
@sylvioalves sylvioalves changed the title hotfix: boards: update m5stack_cores3 configuration fix: boards: update m5stack_cores3 configuration Nov 18, 2024
@sylvioalves sylvioalves removed the Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. label Nov 18, 2024
@sylvioalves sylvioalves force-pushed the bugfix/boards_m5stack_cores3 branch from c001d9b to 65ac181 Compare November 18, 2024 00:52
marekmatej
marekmatej previously approved these changes Nov 18, 2024
Copy link

@marekmatej marekmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This board has a few issues handled by this PR:
- Fix DTS entries to meet necessary flash partitions
- Fix wrong kconfig entries realted to SoC model

Signed-off-by: Sylvio Alves <[email protected]>
Modify this board docs to meet latest changes.

Signed-off-by: Sylvio Alves <[email protected]>
This reverts commit 410c8a5 so that
m5stack_cores3 can be tested properly.

Signed-off-by: Sylvio Alves <[email protected]>
@nashif nashif merged commit fecf909 into zephyrproject-rtos:main Nov 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build/twister fail: m5stack_cores3/esp32s3/appcpu samples/synchronization

6 participants